slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Tue, 8 Dec 2020 01:54:32 +0000 (09:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Dec 2020 15:23:56 +0000 (16:23 +0100)
commit428bb001143cf5bfb65aa4ae90d4ebc95f82d007
tree03e684366fd9242540b2cae90de4a8f8e2fa3aac
parent1c12c27086dcef853832a7cbebcb48bdac8104b6
slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()

platform_get_resource_byname() may fail and in this case a NULL
dereference will occur.

Fix it to use devm_platform_ioremap_resource_byname() instead of calling
platform_get_resource_byname() and devm_ioremap().

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t,
n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607392473-20610-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/slimbus/qcom-ctrl.c