ACPI: PM: Fix regression in acpi_device_set_power()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 31 Jul 2019 23:31:08 +0000 (01:31 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 1 Aug 2019 21:39:17 +0000 (23:39 +0200)
commit42787ed79638dc7f0f8d5c164caba1e87bfab50f
tree820e3d26cac6f1e699c4bdd709de7c4d05b17915
parent609488bc979f99f805f34e9a32c1e3b71179d10b
ACPI: PM: Fix regression in acpi_device_set_power()

Commit f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in
special cases") overlooked the fact that acpi_power_transition() may
change the power.state value for the target device and if that
happens, it may confuse acpi_device_set_power() and cause it to
omit the _PS0 evaluation which on some systems is necessary to
change power states of devices from low-power to D0.

Fix that by saving the current value of power.state for the
target device before passing it to acpi_power_transition() and
using the saved value in a subsequent check.

Fixes: f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in special cases")
Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reported-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: Mario Limonciello <mario.limonciello@dell.com>
drivers/acpi/device_pm.c