Drivers: hv: vmbus: Use after free in __vmbus_open()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Apr 2021 10:50:04 +0000 (13:50 +0300)
committerWei Liu <wei.liu@kernel.org>
Fri, 16 Apr 2021 10:36:33 +0000 (10:36 +0000)
commit3e9bf43f7f7a46f21ec071cb47be92d0874c48da
tree00bfee82ecc1c1b8d9c18fdd7bc873453b9c3416
parent61d74d8e39c88cd5d4300162a0cf96b01b8218d2
Drivers: hv: vmbus: Use after free in __vmbus_open()

The "open_info" variable is added to the &vmbus_connection.chn_msg_list,
but the error handling frees "open_info" without removing it from the
list.  This will result in a use after free.  First remove it from the
list, and then free it.

Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrea Parri <parri.andrea@gmail.com>
Link: https://lore.kernel.org/r/YHV3XLCot6xBS44r@mwanda
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/channel.c