btrfs: eliminate total_size parameter from setup_items_for_insert
authorNikolay Borisov <nborisov@suse.com>
Tue, 1 Sep 2020 14:39:58 +0000 (17:39 +0300)
committerDavid Sterba <dsterba@suse.com>
Wed, 7 Oct 2020 10:13:18 +0000 (12:13 +0200)
commit3dc9dc8969dc738285cb7d43e852c98459c8f0a9
treeea1c82d5921d5eb693da5eb98430aa0b28a27c21
parentfc0716c2f6afed06a9306db3fb62cc1fcf389757
btrfs: eliminate total_size parameter from setup_items_for_insert

The value of this argument can be derived from the total_data as it's
simply the value of the data size + size of btrfs_items being touched.
Move the parameter calculation inside the function. This results in a
simpler interface and also a minor size reduction:

./scripts/bloat-o-meter ctree.original fs/btrfs/ctree.o
add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-34 (-34)
Function                                     old     new   delta
btrfs_duplicate_item                         260     259      -1
setup_items_for_insert                      1200    1190     -10
btrfs_insert_empty_items                     177     154     -23

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c
fs/btrfs/ctree.h
fs/btrfs/delayed-inode.c
fs/btrfs/file.c
fs/btrfs/tests/extent-buffer-tests.c
fs/btrfs/tests/inode-tests.c