thermal: core: Fix use-after-free in thermal_cooling_device_destroy_sysfs
authorDmitry Osipenko <digetx@gmail.com>
Mon, 13 Aug 2018 17:14:00 +0000 (20:14 +0300)
committerZhang Rui <rui.zhang@intel.com>
Wed, 10 Oct 2018 03:44:52 +0000 (11:44 +0800)
commit3c587768271e9c20276522025729e4ebca51583b
treef82b5120fc133b3eb0f02cc0a18ef2def4b5d9b2
parent0238df646e6224016a45505d2c111a24669ebe21
thermal: core: Fix use-after-free in thermal_cooling_device_destroy_sysfs

This patch fixes use-after-free that was detected by KASAN. The bug is
triggered on a CPUFreq driver module unload by freeing 'cdev' on device
unregister and then using the freed structure during of the cdev's sysfs
data destruction. The solution is to unregister the sysfs at first, then
destroy sysfs data and finally release the cooling device.

Cc: <stable@vger.kernel.org> # v4.17+
Fixes: 8ea229511e06 ("thermal: Add cooling device's statistics in sysfs")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
drivers/thermal/thermal_core.c