drm/sched: warn about drm_sched_job_init()'s partial init
authorPhilipp Stanner <pstanner@redhat.com>
Wed, 23 Oct 2024 14:15:31 +0000 (16:15 +0200)
committerPhilipp Stanner <pstanner@redhat.com>
Fri, 25 Oct 2024 16:02:04 +0000 (18:02 +0200)
commit3ae80b375739495e36fc6143ff27716fe390a13e
tree53c20f4d0948f48ac76b896fe51a81bfccc5a3c0
parent581d1f8248550f2b67847e6d84f29fbe3751ea0a
drm/sched: warn about drm_sched_job_init()'s partial init

drm_sched_job_init()'s name suggests that after the function succeeded,
parameter "job" will be fully initialized. This is not the case; some
members are only later set, notably drm_sched_job.sched by
drm_sched_job_arm().

Document that drm_sched_job_init() does not set all struct members.

Document the lifetime of drm_sched_job.sched.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241023141530.113370-2-pstanner@redhat.com
drivers/gpu/drm/scheduler/sched_main.c
include/drm/gpu_scheduler.h