scsi: qla2xxx: Avoid double completion of abort command
authorBen Hutchings <ben.hutchings@codethink.co.uk>
Tue, 20 Mar 2018 21:05:48 +0000 (21:05 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Apr 2018 01:03:41 +0000 (21:03 -0400)
commit3a9910d7b686546dcc9986e790af17e148f1c888
tree29d2ddf2e8ba4043865e6e1a2989ca2d3a421fbe
parent6d6340672ba3a99c4cf7af79c2edf7aa25595c84
scsi: qla2xxx: Avoid double completion of abort command

qla2x00_tmf_sp_done() now deletes the timer that will run
qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer already
expired.  Check the return value from del_timer() to avoid calling
complete() a second time.

Fixes: 4440e46d5db7 ("[SCSI] qla2xxx: Add IOCB Abort command asynchronous ...")
Fixes: 1514839b3664 ("scsi: qla2xxx: Fix NULL pointer crash due to active ...")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_init.c