net: dsa: qca8k: return with -EINVAL on invalid port
authorColin Ian King <colin.i.king@gmail.com>
Thu, 24 Feb 2022 22:05:57 +0000 (22:05 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 26 Feb 2022 06:21:24 +0000 (22:21 -0800)
commit38455fbcc8ece5d4bdc0e6f380abd88db0b208e6
treea3e26b806c03cefb8d312946f4295b51d51e7eef
parent5ebaaa69bd272c654a9e27e83632ae98a0b3c00e
net: dsa: qca8k: return with -EINVAL on invalid port

Currently an invalid port throws a WARN_ON warning however invalid
uninitialized values in reg and cpu_port_index are being used later
on. Fix this by returning -EINVAL for an invalid port value.

Addresses clang-scan warnings:
drivers/net/dsa/qca8k.c:1981:3: warning: 2nd function call argument is an
  uninitialized value [core.CallAndMessage]
drivers/net/dsa/qca8k.c:1999:9: warning: 2nd function call argument is an
  uninitialized value [core.CallAndMessage]

Fixes: 7544b3ff745b ("net: dsa: qca8k: move pcs configuration")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220224220557.147075-1-colin.i.king@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/qca8k.c