rtc: amlogic-a4: fix double free caused by devm
authorHaotian Zhang <vulab@iscas.ac.cn>
Tue, 21 Oct 2025 10:35:59 +0000 (18:35 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 31 Oct 2025 14:10:01 +0000 (15:10 +0100)
commit384150d7a5b60c1086790a8ee07b0629f906cca2
tree160aa3c93cb3e6a8eabd90ffef35e9f61f037383
parent3a8660878839faadb4f1a6dd72c3179c1df56787
rtc: amlogic-a4: fix double free caused by devm

The clock obtained via devm_clk_get_enabled() is automatically managed
by devres and will be disabled and freed on driver detach. Manually
calling clk_disable_unprepare() in error path and remove function
causes double free.

Remove the redundant clk_disable_unprepare() calls from the probe
error path and aml_rtc_remove(), allowing the devm framework to
automatically manage the clock lifecycle.

Fixes: c89ac9182ee2 ("rtc: support for the Amlogic on-chip RTC")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Link: https://patch.msgid.link/20251021103559.1903-1-vulab@iscas.ac.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-amlogic-a4.c