drivers/video: Fix -Wstringop-truncation in hdmi.c
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 21 Oct 2020 12:12:41 +0000 (14:12 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 3 Nov 2020 09:38:06 +0000 (10:38 +0100)
commit35bed3fa9ec58a5b5406c60f66faff86f00fa86b
tree8bdb5c4cde247bdca8f4f259d28444b8a2383427
parent7d6763ab77b3c047cf7d31ca7c4b799808a684a6
drivers/video: Fix -Wstringop-truncation in hdmi.c

Trying to copy into the string fields with strncpy() gives a warning from
gcc. Both fields are part of a packed HDMI header and do not require a
terminating \0 character.

../drivers/video/hdmi.c: In function 'hdmi_spd_infoframe_init':
../drivers/video/hdmi.c:230:2: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
  230 |  strncpy(frame->vendor, vendor, sizeof(frame->vendor));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/video/hdmi.c:231:2: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
  231 |  strncpy(frame->product, product, sizeof(frame->product));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Just use memcpy() instead.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201021121241.17623-1-tzimmermann@suse.de
drivers/video/hdmi.c