vsock: Update rx_bytes on read_skb()
authorMichal Luczaj <mhal@rbox.co>
Sun, 13 Oct 2024 16:26:40 +0000 (18:26 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 17 Oct 2024 11:02:54 +0000 (13:02 +0200)
commit3543152f2d330141d9394d28855cb90b860091d2
tree22d8a715b06c49f14985b2025b9d1bc8a8525014
parent9c5bd93edf7b8834aecaa7c340b852d5990d7c78
vsock: Update rx_bytes on read_skb()

Make sure virtio_transport_inc_rx_pkt() and virtio_transport_dec_rx_pkt()
calls are balanced (i.e. virtio_vsock_sock::rx_bytes doesn't lie) after
vsock_transport::read_skb().

While here, also inform the peer that we've freed up space and it has more
credit.

Failing to update rx_bytes after packet is dequeued leads to a warning on
SOCK_STREAM recv():

[  233.396654] rx_queue is empty, but rx_bytes is non-zero
[  233.396702] WARNING: CPU: 11 PID: 40601 at net/vmw_vsock/virtio_transport_common.c:589

Fixes: 634f1a7110b4 ("vsock: support sockmap")
Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20241013-vsock-fixes-for-redir-v2-2-d6577bbfe742@rbox.co
net/vmw_vsock/virtio_transport_common.c