fpga: machxo2-spi: Return an error on failure
authorTom Rix <trix@redhat.com>
Tue, 10 Aug 2021 16:40:36 +0000 (09:40 -0700)
committerMoritz Fischer <mdf@kernel.org>
Wed, 15 Sep 2021 21:01:17 +0000 (14:01 -0700)
commit34331739e19fd6a293d488add28832ad49c9fc54
treeb2cccaac236f93ac305c0692bed017b2f6df17d6
parent6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
fpga: machxo2-spi: Return an error on failure

Earlier successes leave 'ret' in a non error state, so these errors are
not reported. Set ret to -EINVAL before going to the error handler.

This addresses two issues reported by smatch:
drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
  warn: missing error code 'ret'

drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
  warn: missing error code 'ret'

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
drivers/fpga/machxo2-spi.c