dmaengine: ti: omap-dma: Skip pointless cpu_pm context restore on errors
authorTony Lindgren <tony@atomide.com>
Tue, 18 May 2021 07:43:47 +0000 (10:43 +0300)
committerVinod Koul <vkoul@kernel.org>
Mon, 31 May 2021 04:31:53 +0000 (10:01 +0530)
commit340ad031887b89af4467ee078e22d24aad0d8401
treecf4137726b4d2d38ee333156ae346d1a91271447
parent66fde1794ffd075c1b2026d8956f667704c76920
dmaengine: ti: omap-dma: Skip pointless cpu_pm context restore on errors

There's no need to restore DMA context on CPU_CLUSTER_PM_ENTER_FAILED as
the DMA context won't be lost on errors.

Note that this does not cause invalid context restore as we already check
for busy DMA with omap_dma_busy() in CPU_CLUSTER_PM_ENTER, and block any
deeper idle states for the SoC by returning NOTIFY_BAD if busy.

If other drivers block deeper idle states with cpu_pm, we now just do a
pointless restore, but only if dma was not busy on CPU_CLUSTER_PM_ENTER.

Let's update the CPU_CLUSTER_PM_ENTER_FAILED handling for correctness,
and add a comment.

Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Adam Ford <aford173@gmail.com>
Cc: Andreas Kemnade <andreas@kemnade.info>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20210518074347.16908-1-tony@atomide.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/omap-dma.c