scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
authorBodo Stroesser <bostroesser@gmail.com>
Tue, 17 May 2022 19:29:13 +0000 (21:29 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 May 2022 00:16:27 +0000 (20:16 -0400)
commit325d5c5fb216674296f3902a8902b942da3adc5b
tree98cee22612befcbff95316d83366e73fc4e6ecd2
parentd627660c22b51121262c03dfa1a51bf54361f5a9
scsi: target: tcmu: Avoid holding XArray lock when calling lock_page

In tcmu_blocks_release(), lock_page() is called to prevent a race causing
possible data corruption. Since lock_page() might sleep, calling it while
holding XArray lock is a bug.

To fix this, replace the xas_for_each() call with xa_for_each_range().
Since the latter does its own handling of XArray locking, the xas_lock()
and xas_unlock() calls around the original loop are no longer necessary.

The switch to xa_for_each_range() slows down the loop slightly. This is
acceptable since tcmu_blocks_release() is not relevant for performance.

Link: https://lore.kernel.org/r/20220517192913.21405-1-bostroesser@gmail.com
Fixes: bb9b9eb0ae2e ("scsi: target: tcmu: Fix possible data corruption")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bodo Stroesser <bostroesser@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c