rxrpc: Fix the return value of rxrpc_new_incoming_call()
authorDavid Howells <dhowells@redhat.com>
Thu, 15 Dec 2022 16:20:55 +0000 (16:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Dec 2022 09:51:31 +0000 (09:51 +0000)
commit31d35a02ad5b803354fe0727686fcbace7a343fe
tree60b7032a9d53f6e0032e333c1273e3a421629914
parent11e1706bc84f60040578056f8cef3d0139b92dda
rxrpc: Fix the return value of rxrpc_new_incoming_call()

Dan Carpenter sayeth[1]:

  The patch 5e6ef4f1017c: "rxrpc: Make the I/O thread take over the
  call and local processor work" from Jan 23, 2020, leads to the
  following Smatch static checker warning:

net/rxrpc/io_thread.c:283 rxrpc_input_packet()
warn: bool is not less than zero.

Fix this (for now) by changing rxrpc_new_incoming_call() to return an int
with 0 or error code rather than bool.  Note that the actual return value
of rxrpc_input_packet() is currently ignored.  I have a separate patch to
clean that up.

Fixes: 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: http://lists.infradead.org/pipermail/linux-afs/2022-December/006123.html
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rxrpc/ar-internal.h
net/rxrpc/call_accept.c
net/rxrpc/io_thread.c