AX.25: Fix out-of-bounds read in ax25_connect()
authorPeilin Ye <yepeilin.cs@gmail.com>
Wed, 22 Jul 2020 15:19:01 +0000 (11:19 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Jul 2020 00:56:40 +0000 (17:56 -0700)
commit2f2a7ffad5c6cbf3d438e813cfdc88230e185ba6
treedb2289e67686fae52fea86f60b8d80e0dcdb3f36
parent26cb7085c8984e5b71d65c374a135134ed8cabb3
AX.25: Fix out-of-bounds read in ax25_connect()

Checks on `addr_len` and `fsa->fsa_ax25.sax25_ndigis` are insufficient.
ax25_connect() can go out of bounds when `fsa->fsa_ax25.sax25_ndigis`
equals to 7 or 8. Fix it.

This issue has been reported as a KMSAN uninit-value bug, because in such
a case, ax25_connect() reaches into the uninitialized portion of the
`struct sockaddr_storage` statically allocated in __sys_connect().

It is safe to remove `fsa->fsa_ax25.sax25_ndigis > AX25_MAX_DIGIS` because
`addr_len` is guaranteed to be less than or equal to
`sizeof(struct full_sockaddr_ax25)`.

Reported-by: syzbot+c82752228ed975b0a623@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=55ef9d629f3b3d7d70b69558015b63b48d01af66
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ax25/af_ax25.c