KVM: Destroy I/O bus devices on unregister failure _after_ sync'ing SRCU
authorSean Christopherson <seanjc@google.com>
Mon, 12 Apr 2021 22:20:48 +0000 (15:20 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 20 Apr 2021 08:18:50 +0000 (04:18 -0400)
commit2ee3757424be7c1cd1d0bbfa6db29a7edd82a250
tree3eabada22014fdb94656ec8e897a922a7a05e1ad
parent24e7475f931ad7090c1e63dbaf12f338aeb81eac
KVM: Destroy I/O bus devices on unregister failure _after_ sync'ing SRCU

If allocating a new instance of an I/O bus fails when unregistering a
device, wait to destroy the device until after all readers are guaranteed
to see the new null bus.  Destroying devices before the bus is nullified
could lead to use-after-free since readers expect the devices on their
reference of the bus to remain valid.

Fixes: f65886606c2d ("KVM: fix memory leak in kvm_io_bus_unregister_dev()")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20210412222050.876100-2-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/kvm_main.c