dissector: do not set invalid PPP protocol
authorBoris Sukholitko <boris.sukholitko@broadcom.com>
Wed, 29 Sep 2021 11:32:23 +0000 (14:32 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 Sep 2021 12:09:28 +0000 (13:09 +0100)
commit2e861e5e97175dfa7b7bc055c45acdc06d2301d3
tree242a5046fe2599bb99cee7ba24223dc9ec583a28
parent55b115c7ecd9440610a58967321d9a4dc52b5f0e
dissector: do not set invalid PPP protocol

The following flower filter fails to match non-PPP_IP{V6} packets
wrapped in PPP_SES protocol:

tc filter add dev eth0 ingress protocol ppp_ses flower \
        action simple sdata hi64

The reason is that proto local variable is being set even when
FLOW_DISSECT_RET_OUT_BAD status is returned.

The fix is to avoid setting proto variable if the PPP protocol is unknown.

Signed-off-by: Boris Sukholitko <boris.sukholitko@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow_dissector.c