rbd: check snap_count against RBD_MAX_SNAP_COUNT
authorRosen Penev <rosenp@gmail.com>
Sat, 30 May 2026 01:12:55 +0000 (18:12 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 1 Jun 2026 01:48:53 +0000 (19:48 -0600)
commit2e1b3f4c51ace14f67201bd2a92ca6312a3c3724
tree8364182ec6571fbee68708054d7e91476b60f94b
parent2957771379fa335103a4b539db57bb2271e12142
rbd: check snap_count against RBD_MAX_SNAP_COUNT

snap_count is u32 but the comparison is against a SIZE_MAX-derived value
(~2^61 on 64-bit), which clang flags as always false with
-Wtautological-constant-out-of-range-compare.

The proper check here should be that snap_count does not go over
RBD_MAX_SNAP_COUNT.

Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Alex Elder <elder@riscstar.com>
Link: https://patch.msgid.link/20260530011255.52916-1-rosenp@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rbd.c