ALSA: drivers: opl3: Fix incorrect use of vp->state
authorColin Ian King <colin.i.king@gmail.com>
Sun, 12 Dec 2021 17:20:25 +0000 (17:20 +0000)
committerTakashi Iwai <tiwai@suse.de>
Mon, 13 Dec 2021 09:36:17 +0000 (10:36 +0100)
commit2dee54b289fbc810669a1b2b8a0887fa1c9a14d7
tree3c31b6e3c35b1b7b2f89ef38908cea930b1aedd2
parentd7f32791a9fcf0dae8b073cdea9b79e29098c5f4
ALSA: drivers: opl3: Fix incorrect use of vp->state

Static analysis with scan-build has found an assignment to vp2 that is
never used. It seems that the check on vp->state > 0 should be actually
on vp2->state instead. Fix this.

This dates back to 2002, I found the offending commit from the git
history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20211212172025.470367-1-colin.i.king@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/opl3/opl3_midi.c