nfsd: call nfsd_last_thread() before final nfsd_put()
authorNeilBrown <neilb@suse.de>
Fri, 15 Dec 2023 00:56:31 +0000 (11:56 +1100)
committerChuck Lever <chuck.lever@oracle.com>
Fri, 15 Dec 2023 15:23:46 +0000 (10:23 -0500)
commit2a501f55cd641eb4d3c16a2eab0d678693fac663
tree2a18ad5f59faa05fb603a973f45060b1aef7db2b
parentbf51c52a1f3c238d72c64e14d5e7702d3a245b82
nfsd: call nfsd_last_thread() before final nfsd_put()

If write_ports_addfd or write_ports_addxprt fail, they call nfsd_put()
without calling nfsd_last_thread().  This leaves nn->nfsd_serv pointing
to a structure that has been freed.

So remove 'static' from nfsd_last_thread() and call it when the
nfsd_serv is about to be destroyed.

Fixes: ec52361df99b ("SUNRPC: stop using ->sv_nrthreads as a refcount")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsctl.c
fs/nfsd/nfsd.h
fs/nfsd/nfssvc.c