projects / linux-2.6-microblaze.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cd8c0bb) | patch
rtc: r7301: Fix a possible sleep-in-atomic bug in rtc7301_set_time
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 13 Dec 2017 13:56:04 +0000 (21:56 +0800)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 11 Jan 2018 23:20:34 +0000 (00:20 +0100)
commit298c8545206b2dd963079ff48fafd909e099856e
treeb8d9e8a26bf916072856f5f9865dc680162bc49etree
parentcd8c0bb2bd57c48c451ebea86065257ef2500b00commit | diff
rtc: r7301: Fix a possible sleep-in-atomic bug in rtc7301_set_time

The driver may sleep under a spinlock.
The function call path is:
rtc7301_set_time (acquire the spinlock)
  usleep_range --> may sleep

To fix it, usleep_range is replaced with udelay.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-r7301.c diff | blob | history
MicroBlaze GIT Repository