mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 29 Jan 2021 14:37:24 +0000 (17:37 +0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 8 Feb 2021 13:54:40 +0000 (13:54 +0000)
commit26783d74cc6a440ee3ef9836a008a697981013d0
tree62c46c1bde92a726a3a852ed54b07cc0dede7e3d
parent6a8fac01dc1c6508dd7cab876170024070b71039
mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()

The "req" struct is always added to the "wm831x->auxadc_pending" list,
but it's only removed from the list on the success path.  If a failure
occurs then the "req" struct is freed but it's still on the list,
leading to a use after free.

Fixes: 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/wm831x-auxadc.c