drm/vmwgfx: Handle surface check failure correctly
authorNikolay Kuratov <kniv@yandex-team.ru>
Wed, 2 Oct 2024 12:24:29 +0000 (15:24 +0300)
committerZack Rusin <zack.rusin@broadcom.com>
Thu, 10 Oct 2024 18:35:24 +0000 (14:35 -0400)
commit26498b8d54373d31a621d7dec95c4bd842563b3b
treeeaf5174b954e9c9e5beac1d50dcd804e37a37d9b
parent512a9721cae0d88d34ff441f2f5917cd149af8af
drm/vmwgfx: Handle surface check failure correctly

Currently if condition (!bo and !vmw_kms_srf_ok()) was met
we go to err_out with ret == 0.
err_out dereferences vfb if ret == 0, but in our case vfb is still NULL.

Fix this by assigning sensible error to ret.

Found by Linux Verification Center (linuxtesting.org) with SVACE

Signed-off-by: Nikolay Kuratov <kniv@yandex-team.ru>
Cc: stable@vger.kernel.org
Fixes: 810b3e1683d0 ("drm/vmwgfx: Support topology greater than texture size")
Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241002122429.1981822-1-kniv@yandex-team.ru
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c