Improve __fget_files_rcu() code generation (and thus __fget_light())
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 26 Nov 2023 20:24:38 +0000 (12:24 -0800)
committerChristian Brauner <brauner@kernel.org>
Tue, 12 Dec 2023 13:24:13 +0000 (14:24 +0100)
commit253ca8678d30bcf94410b54476fc1e0f1627a137
tree4727be75e2660bf1a1a54701f16dddb74a35b335
parent7cb537b6f6d7d6529be04139178f929d9a63b918
Improve __fget_files_rcu() code generation (and thus __fget_light())

Commit 0ede61d8589c ("file: convert to SLAB_TYPESAFE_BY_RCU") caused a
performance regression as reported by the kernel test robot.

The __fget_light() function is one of those critical ones for some
loads, and the code generation was unnecessarily impacted.  Let's just
write that function to better.

Reported-by: kernel test robot <oliver.sang@intel.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Jann Horn <jannh@google.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Closes: https://lore.kernel.org/oe-lkp/202311201406.2022ca3f-oliver.sang@intel.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/CAHk-=wiCJtLbFWNURB34b9a_R_unaH3CiMRXfkR0-iihB_z68A@mail.gmail.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/file.c
include/linux/fdtable.h