fs: Fix page_mkwrite off-by-one errors
authorAndreas Gruenbacher <agruenba@redhat.com>
Mon, 6 Jan 2020 16:58:23 +0000 (08:58 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 6 Jan 2020 16:58:23 +0000 (08:58 -0800)
commit243145bc4336684c69f95de0a303b31f2e5bf264
tree1a5bf570c07209e01f80c93118d0e960545b697d
parentfd6988496e79a6a4bdb514a4655d2920209eb85d
fs: Fix page_mkwrite off-by-one errors

The check in block_page_mkwrite that is meant to determine whether an
offset is within the inode size is off by one.  This bug has been copied
into iomap_page_mkwrite and several filesystems (ubifs, ext4, f2fs,
ceph).

Fix that by introducing a new page_mkwrite_check_truncate helper that
checks for truncate and computes the bytes in the page up to EOF.  Use
the helper in iomap.

NOTE from Darrick: The original patch fixed a number of filesystems, but
then there were merge conflicts with the f2fs for-next tree; a
subsequent re-submission of the patch had different btrfs changes with
no explanation; and Christoph complained that each per-fs fix should be
a separate patch.  In my view that's too much risk to take on, so I
decided to drop all the hunks except for iomap, since I've actually QA'd
XFS.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[darrick: drop everything but the iomap parts]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/iomap/buffered-io.c
include/linux/pagemap.h