ACPI: sleep: Avoid breaking S3 wakeup due to might_sleep()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 14 Jun 2023 15:29:21 +0000 (17:29 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 15 Jun 2023 16:05:19 +0000 (18:05 +0200)
commit22db06337f590d01d79f60f181d8dfe5a9ef9085
tree7813cfc4fb4a23cae97949be8144b32d49b38198
parent858fd168a95c5b9669aac8db6c14a9aeab446375
ACPI: sleep: Avoid breaking S3 wakeup due to might_sleep()

The addition of might_sleep() to down_timeout() caused the latter to
enable interrupts unconditionally in some cases, which in turn broke
the ACPI S3 wakeup path in acpi_suspend_enter(), where down_timeout()
is called by acpi_disable_all_gpes() via acpi_ut_acquire_mutex().

Namely, if CONFIG_DEBUG_ATOMIC_SLEEP is set, might_sleep() causes
might_resched() to be used and if CONFIG_PREEMPT_VOLUNTARY is set,
this triggers __cond_resched() which may call preempt_schedule_common(),
so __schedule() gets invoked and it ends up with enabled interrupts (in
the prev == next case).

Now, enabling interrupts early in the S3 wakeup path causes the kernel
to crash.

Address this by modifying acpi_suspend_enter() to disable GPEs without
attempting to acquire the sleeping lock which is not needed in that code
path anyway.

Fixes: 99409b935c9a ("locking/semaphore: Add might_sleep() to down_*() family")
Reported-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: 5.15+ <stable@vger.kernel.org> # 5.15+
drivers/acpi/acpica/achware.h
drivers/acpi/sleep.c
include/acpi/acpixf.h