libbpf: Fix memory leak and possible double-free in hashmap__clear
authorAndrii Nakryiko <andriin@fb.com>
Wed, 29 Apr 2020 01:21:04 +0000 (18:21 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 29 Apr 2020 02:48:05 +0000 (19:48 -0700)
commit229bf8bf4d910510bc1a2fd0b89bd467cd71050d
treecddf013296aff40219e40f654f9c212bd1f070c9
parent42fce2cfb405e613f0355c4f92429d651bf0a5b3
libbpf: Fix memory leak and possible double-free in hashmap__clear

Fix memory leak in hashmap_clear() not freeing hashmap_entry structs for each
of the remaining entries. Also NULL-out bucket list to prevent possible
double-free between hashmap__clear() and hashmap__free().

Running test_progs-asan flavor clearly showed this problem.

Reported-by: Alston Tang <alston64@fb.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200429012111.277390-5-andriin@fb.com
tools/lib/bpf/hashmap.c