sched/autogroup: Fix failure to set cpu.rt_runtime_us
authorPeter Zijlstra <peterz@infradead.org>
Mon, 9 Feb 2015 10:53:18 +0000 (11:53 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 18 Feb 2015 15:17:20 +0000 (16:17 +0100)
commit1fe89e1b6d270aa0d3452c60d38461ea589594e3
treeed9a44ec4e104281dd17e0be30e7b4525d9b0b51
parent6f1607f1bdb4f9991a8123675a03c1764b2932fe
sched/autogroup: Fix failure to set cpu.rt_runtime_us

Because task_group() uses a cache of autogroup_task_group(), whose
output depends on sched_class, switching classes can generate
problems.

In particular, when started as fair, the cache points to the
autogroup, so when switching to RT the tg_rt_schedulable() test fails
for every cpu.rt_{runtime,period}_us change because now the autogroup
has tasks and no runtime.

Furthermore, going back to the previous semantics of varying
task_group() with sched_class has the down-side that the sched_debug
output varies as well, even though the task really is in the
autogroup.

Therefore add an autogroup exception to tg_has_rt_tasks() -- such that
both (all) task_group() usages in sched/core now have one. And remove
all the remnants of the variable task_group() output.

Reported-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Stefan Bader <stefan.bader@canonical.com>
Fixes: 8323f26ce342 ("sched: Fix race in task_group()")
Link: http://lkml.kernel.org/r/20150209112237.GR5029@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/auto_group.c
kernel/sched/core.c