sctp: update hb timer immediately after users change hb_interval
authorXin Long <lucien.xin@gmail.com>
Sun, 1 Oct 2023 15:04:20 +0000 (11:04 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Oct 2023 00:29:58 +0000 (17:29 -0700)
commit1f4e803cd9c9166eb8b6c8b0b8e4124f7499fc07
treeb74d9a3545e465c50dd47390b7dd31705be90056
parent2222a78075f0c19ca18db53fd6623afb4aff602d
sctp: update hb timer immediately after users change hb_interval

Currently, when hb_interval is changed by users, it won't take effect
until the next expiry of hb timer. As the default value is 30s, users
have to wait up to 30s to wait its hb_interval update to work.

This becomes pretty bad in containers where a much smaller value is
usually set on hb_interval. This patch improves it by resetting the
hb timer immediately once the value of hb_interval is updated by users.

Note that we don't address the already existing 'problem' when sending
a heartbeat 'on demand' if one hb has just been sent(from the timer)
mentioned in:

  https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg590224.html

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Link: https://lore.kernel.org/r/75465785f8ee5df2fb3acdca9b8fafdc18984098.1696172660.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/socket.c