net: phy: mediatek: fix nvmem cell reference leak in mt798x_phy_calibration
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 11 Dec 2025 08:13:13 +0000 (12:13 +0400)
committerPaolo Abeni <pabeni@redhat.com>
Mon, 22 Dec 2025 11:18:54 +0000 (12:18 +0100)
commit1e5a541420b8c6d87d88eb50b6b978cdeafee1c9
tree3906838f73f74b4beb331d9a50b0823c7cc37855
parent15ef641a0c6728d25a400df73922e80ab2cf029c
net: phy: mediatek: fix nvmem cell reference leak in mt798x_phy_calibration

When nvmem_cell_read() fails in mt798x_phy_calibration(), the function
returns without calling nvmem_cell_put(), leaking the cell reference.

Move nvmem_cell_put() right after nvmem_cell_read() to ensure the cell
reference is always released regardless of the read result.

Found via static analysis and code review.

Fixes: 98c485eaf509 ("net: phy: add driver for MediaTek SoC built-in GE PHYs")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20251211081313.2368460-1-linmq006@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/phy/mediatek/mtk-ge-soc.c