pinctrl: sh-pfc: Make legacy function GPIO handling less fragile
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 13 Nov 2019 10:18:09 +0000 (11:18 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 9 Dec 2019 08:43:02 +0000 (09:43 +0100)
commit1d0f9e1e1e46939ae52804917647982b43754996
tree53e673f338e43cb9dd45ea8709caf2f8f9883537
parente42617b825f8073569da76dc4510bfa019b1c35a
pinctrl: sh-pfc: Make legacy function GPIO handling less fragile

If there are no function GPIOs, sh_pfc_register_gpiochip() returns early
with a success indicator.  This is fragile, as new code may be added
after the #ifdef block, which won't be executed in case of early return.

Invert the logic, so the code always continues until the end of the
function on success.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20191113101809.28600-1-geert+renesas@glider.be
drivers/pinctrl/sh-pfc/gpio.c