perf probe: Ensure offset provided is not greater than function length without DWARF...
authorPrashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Tue, 28 Feb 2012 04:13:01 +0000 (09:43 +0530)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 29 Feb 2012 21:29:46 +0000 (18:29 -0300)
commit1c1bc9223387dacc48eb2b61b0baabe7e9cf47f6
tree873357b11c3423f2b8798b0c9e8e5ac18735db66
parentcfbd70c17c4535e64be92ea442a2a45078a18184
perf probe: Ensure offset provided is not greater than function length without DWARF info too

The 'perf probe' command allows kprobe to be inserted at any offset from
a function start, which results in adding kprobes to unintended
location.  (example: perf probe do_fork+10000 is allowed even though
size of do_fork is ~904).

My previous patch https://lkml.org/lkml/2012/2/24/42 addressed the case
where DWARF info was available for the kernel. This patch fixes the
case where perf probe is used on a kernel without debuginfo available.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/4F4C544D.1010909@linux.vnet.ibm.com
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-event.c