io_uring/io-wq: close io-wq full-stop gap
authorPavel Begunkov <asml.silence@gmail.com>
Sun, 23 May 2021 14:48:39 +0000 (15:48 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 26 May 2021 01:39:58 +0000 (19:39 -0600)
commit17a91051fe63b40ec651b80097c9fff5b093fdc5
tree2ff23057d8bb5cbbed0b123eb9a8b3dd803c1586
parentba5ef6dc8a827a904794210a227cdb94828e8ae7
io_uring/io-wq: close io-wq full-stop gap

There is an old problem with io-wq cancellation where requests should be
killed and are in io-wq but are not discoverable, e.g. in @next_hashed
or @linked vars of io_worker_handle_work(). It adds some unreliability
to individual request canellation, but also may potentially get
__io_uring_cancel() stuck. For instance:

1) An __io_uring_cancel()'s cancellation round have not found any
   request but there are some as desribed.
2) __io_uring_cancel() goes to sleep
3) Then workers wake up and try to execute those hidden requests
   that happen to be unbound.

As we already cancel all requests of io-wq there, set IO_WQ_BIT_EXIT
in advance, so preventing 3) from executing unbound requests. The
workers will initially break looping because of getting a signal as they
are threads of the dying/exec()'ing user task.

Cc: stable@vger.kernel.org
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/abfcf8c54cb9e8f7bfbad7e9a0cc5433cc70bdc2.1621781238.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io-wq.c
fs/io-wq.h
fs/io_uring.c