ipv4: Don't reset ->flowi4_scope in ip_rt_fix_tos().
authorGuillaume Nault <gnault@redhat.com>
Wed, 20 Apr 2022 23:21:24 +0000 (01:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Apr 2022 12:06:03 +0000 (13:06 +0100)
commit16a28267774cd9f85405ef83d4afcbd0355e5817
treeda6c5a99699f82f3831eab7e8294ee3f7b4c0345
parentcb1e6bf42bce63158884ab83fb171b518693c771
ipv4: Don't reset ->flowi4_scope in ip_rt_fix_tos().

All callers already initialise ->flowi4_scope with RT_SCOPE_UNIVERSE,
either by manual field assignment, memset(0) of the whole structure or
implicit structure initialisation of on-stack variables
(RT_SCOPE_UNIVERSE actually equals 0).

Therefore, we don't need to always initialise ->flowi4_scope in
ip_rt_fix_tos(). We only need to reduce the scope to RT_SCOPE_LINK when
the special RTO_ONLINK flag is present in the tos.

This will allow some code simplification, like removing
ip_rt_fix_tos(). Also, the long term idea is to remove RTO_ONLINK
entirely by properly initialising ->flowi4_scope, instead of
overloading ->flowi4_tos with a special flag. Eventually, this will
allow to convert ->flowi4_tos to dscp_t.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/route.c