platform/x86: hp_wmi: Fix rfkill causing soft blocked wifi
authorJorge Lopez <jorge.lopez2@hp.com>
Fri, 28 Oct 2022 15:55:27 +0000 (10:55 -0500)
committerHans de Goede <hdegoede@redhat.com>
Mon, 7 Nov 2022 11:33:49 +0000 (12:33 +0100)
commit1598bfa8e1faa932de42e1ee7628a1c4c4263f0a
treece013a8b23a5da1d514d6317cdc308b204a5a356
parent0df044b34bf33e7e35c32b3bf6747fde6279c162
platform/x86: hp_wmi: Fix rfkill causing soft blocked wifi

After upgrading BIOS to U82 01.02.01 Rev.A, the console is flooded
strange char "^@" which printed out every second and makes login
nearly impossible. Also the below messages were shown both in console
and journal/dmesg every second:

usb 1-3: Device not responding to setup address.
usb 1-3: device not accepting address 4, error -71
usb 1-3: device descriptor read/all, error -71
usb usb1-port3: unable to enumerate USB device

Wifi is soft blocked by checking rfkill. When unblocked manually,
after few seconds it would be soft blocked again. So I was suspecting
something triggered rfkill to soft block wifi.  At the end it was
fixed by removing hp_wmi module.

The root cause is the way hp-wmi driver handles command 1B on
post-2009 BIOS.  In pre-2009 BIOS, command 1Bh return 0x4 to indicate
that BIOS no longer controls the power for the wireless devices.

Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216468
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20221028155527.7724-1-jorge.lopez2@hp.com
Cc: stable@vger.kernel.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/hp-wmi.c