s390/cio: fix use-after-free in ccw_device_destroy_console
authorQinglang Miao <miaoqinglang@huawei.com>
Tue, 1 Dec 2020 06:31:50 +0000 (14:31 +0800)
committerHeiko Carstens <hca@linux.ibm.com>
Wed, 9 Dec 2020 20:02:07 +0000 (21:02 +0100)
commit14d4c4fa46eeaa3922e8e1c4aa727eb0a1412804
tree74c4e55967098490304b430d43d34ffc577eb47c
parent8cc0dcfdc1c0e0be107d0288f9c0cf1f4201be62
s390/cio: fix use-after-free in ccw_device_destroy_console

Use of sch->dev reference after the put_device() call could trigger
the use-after-free bugs.

Fix this by simply adjusting the position of put_device.

Fixes: 37db8985b211 ("s390/cio: add basic protected virtualization support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Suggested-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
[vneethv@linux.ibm.com: Slight modification in the commit-message]
Signed-off-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
drivers/s390/cio/device.c