dm cache policy smq: fix alloc_bitset check that always evaluates as false
authorColin Ian King <colin.king@canonical.com>
Thu, 23 Jul 2015 15:47:59 +0000 (16:47 +0100)
committerMike Snitzer <snitzer@redhat.com>
Mon, 27 Jul 2015 11:58:15 +0000 (07:58 -0400)
commit134bf30c06f057d6b8d90132e8f8b3cd2be79572
tree18e54851abf6c3300448b933c150c802894f800b
parent0a927c2f02a2437a57679527e42ab7cbfa14efb1
dm cache policy smq: fix alloc_bitset check that always evaluates as false

static analysis by cppcheck has found a check on alloc_bitset that
always evaluates as false and hence never finds an allocation failure:

[drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction
  always evaluates to false: !EXPR && EXPR.

Fix this by removing the incorrect mq->cache_hit_bits check

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-cache-policy-smq.c