ACPI: PAD: Eliminate usage of uninitialized_var() macro
authorJason Yan <yanaijie@huawei.com>
Mon, 15 Jun 2020 04:00:47 +0000 (12:00 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 24 Jun 2020 15:36:08 +0000 (17:36 +0200)
commit134043cd64c96906c7c04515a745d2073d4d1939
tree44c164fa29aa2d0361971a87860367733fd9bc2a
parent48778464bb7d346b47157d21ffde2af6b2d39110
ACPI: PAD: Eliminate usage of uninitialized_var() macro

This is an effort to eliminate the uninitialized_var() macro[1].

The use of this macro is the wrong solution because it forces off ANY
analysis by the compiler for a given variable. It even masks "unused
variable" warnings.

Quoted from Linus[2]:

"It's a horrible thing to use, in that it adds extra cruft to the
source code, and then shuts up a compiler warning (even the _reliable_
warnings from gcc)."

The gcc option "-Wmaybe-uninitialized" has been disabled and this change
will not produce any warnnings even with "make W=1".

Link: https://github.com/KSPP/linux/issues/81
Link: https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpi_pad.c