bpf: Enforce that struct_ops programs be GPL-only
authorToke Høiland-Jørgensen <toke@redhat.com>
Fri, 26 Mar 2021 10:03:13 +0000 (11:03 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 26 Mar 2021 16:50:39 +0000 (17:50 +0100)
commit12aa8a9467b354ef893ce0fc5719a4de4949a9fb
tree06513a576b906410017c90654a0ff6331b30e1ad
parent6032ebb54c60cae24329f6aba3ce0c1ca8ad6abe
bpf: Enforce that struct_ops programs be GPL-only

With the introduction of the struct_ops program type, it became possible to
implement kernel functionality in BPF, making it viable to use BPF in place
of a regular kernel module for these particular operations.

Thus far, the only user of this mechanism is for implementing TCP
congestion control algorithms. These are clearly marked as GPL-only when
implemented as modules (as seen by the use of EXPORT_SYMBOL_GPL for
tcp_register_congestion_control()), so it seems like an oversight that this
was not carried over to BPF implementations. Since this is the only user
of the struct_ops mechanism, just enforcing GPL-only for the struct_ops
program type seems like the simplest way to fix this.

Fixes: 0baf26b0fcd7 ("bpf: tcp: Support tcp_congestion_ops in bpf")
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20210326100314.121853-1-toke@redhat.com
kernel/bpf/verifier.c