accel/qaic: Pass string literal as format argument of alloc_workqueue()
authorSimon Horman <horms@kernel.org>
Fri, 11 Oct 2024 09:57:12 +0000 (10:57 +0100)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Fri, 18 Oct 2024 19:39:42 +0000 (13:39 -0600)
commit11fc5ce6e2a6316b7d02746c035ee1e51bf10718
tree0803b3b009b98d2ab6c5c463aa5a3f76b837c6d8
parent2063ca42486bc07b49bc145b5dfcb421f4deebaf
accel/qaic: Pass string literal as format argument of alloc_workqueue()

Recently I noticed that both gcc-14 and clang-18 report that passing
a non-string literal as the format argument of alloc_workqueue()
is potentially insecure.

E.g. clang-18 says:

.../qaic_drv.c:61:23: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
   61 |         wq = alloc_workqueue(fmt, WQ_UNBOUND, 0);
      |                              ^~~
.../qaic_drv.c:61:23: note: treat the string as an argument to avoid this
   61 |         wq = alloc_workqueue(fmt, WQ_UNBOUND, 0);
      |                              ^
      |                              "%s",

It is always the case where the contents of fmt is safe to pass as the
format argument. That is, in my understanding, it never contains any
format escape sequences.

But, it seems better to be safe than sorry. And, as a bonus, compiler
output becomes less verbose by addressing this issue as suggested by
clang-18.

Also, change the name of the parameter of qaicm_wq_init from
fmt to name to better reflect it's purpose.

Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Tested-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241011-string-thing-v1-3-acc506568033@kernel.org
drivers/accel/qaic/qaic_drv.c