ext4: fix fsync for non-directories
authorJan Kara <jack@suse.cz>
Wed, 24 May 2023 10:44:53 +0000 (12:44 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 30 May 2023 19:33:57 +0000 (15:33 -0400)
commit1077b2d53ef53629c14106aecf633bebd286c04c
treea20c02beedd015375d027b070959a4153bb64d2d
parentaff3bea95388299eec63440389b4545c8041b357
ext4: fix fsync for non-directories

Commit e360c6ed7274 ("ext4: Drop special handling of journalled data
from ext4_sync_file()") simplified ext4_sync_file() by dropping special
handling of journalled data mode as it was not needed anymore. However
that branch was also used for directories and symlinks and since the
fastcommit code does not track metadata changes to non-regular files, the
change has caused e.g. fsync(2) on directories to not commit transaction
as it should. Fix the problem by adding handling for non-regular files.

Fixes: e360c6ed7274 ("ext4: Drop special handling of journalled data from ext4_sync_file()")
Reported-by: Eric Whitney <enwlinux@gmail.com>
Link: https://lore.kernel.org/all/ZFqO3xVnmhL7zv1x@debian-BULLSEYE-live-builder-AMD64
Signed-off-by: Jan Kara <jack@suse.cz>
Tested-by: Eric Whitney <enwlinux@gmail.com>
Link: https://lore.kernel.org/r/20230524104453.8734-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/fsync.c