projects / linux-2.6-microblaze.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 581df9e) | patch
ipg: fix an unsigned widening cast of '~' truncation issue
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 May 2013 21:20:02 +0000 (21:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 May 2013 21:42:14 +0000 (14:42 -0700)
commit0d709d91b85b71568b41b323d2a2c761f18e5213
treeee22ad6ce525fcdf66fd9ac3bf73e7591b2f718btree
parent581df9e1944194bfcabc57e1efae79b0fe171d6fcommit | diff
ipg: fix an unsigned widening cast of '~' truncation issue

The bug here is this code from ipg_nic_hard_start_xmit():

txfd->tfc &= cpu_to_le64(~IPG_TFC_TFDDONE);

IPG_TFC_TFDDONE is 0x0000000080000000 so it's an unsigned int.  The
negated value is 0x7fffffff but 0xffffffff7fffffff was intended.

The other values in this file don't need to be changed but I did it for
consistency.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/icplus/ipg.h diff | blob | history
MicroBlaze GIT Repository