tcp: correctly test congestion state in RACK
authorYuchung Cheng <ycheng@google.com>
Thu, 7 Dec 2017 19:33:30 +0000 (11:33 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Dec 2017 19:14:11 +0000 (14:14 -0500)
commit0ce294d88457bccd7f9991f883fec80022a1ddbd
tree9b4bb1c98c751b01b0f06fded0e3db0e403b5cfc
parent2edbdb3159d6f6bd3a9b6e7f789f2b879699a519
tcp: correctly test congestion state in RACK

RACK does not test the loss recovery state correctly to compute
the reordering window. It assumes if lost_out is zero then TCP is
not in loss recovery. But it can be zero during recovery before
calling tcp_rack_detect_loss(): when an ACK acknowledges all
packets marked lost before receiving this ACK, but has not yet
to discover new ones by tcp_rack_detect_loss(). The fix is to
simply test the congestion state directly.

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Reviewed-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Priyaranjan Jha <priyarjha@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_recovery.c