Bluetooth: hci_intel: drop strange le16_to_cpu() against u8 values
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 3 Sep 2020 18:48:48 +0000 (21:48 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 11 Sep 2020 06:50:49 +0000 (08:50 +0200)
commit0cc62caf4c8f376f8a846271083379667cf74739
tree4a695bec6998e410a20f37e6bc4d1caa6d81fb8f
parent65a24d4c2712182a3ca450cf9f019ee5ab332533
Bluetooth: hci_intel: drop strange le16_to_cpu() against u8 values

Sparse rightfully complains:

  hci_intel.c:696:26: warning: cast to restricted __le16
  hci_intel.c:701:26: warning: cast to restricted __le16
  hci_intel.c:702:26: warning: cast to restricted __le16
  hci_intel.c:703:26: warning: cast to restricted __le16
  hci_intel.c:725:26: warning: cast to restricted __le16
  hci_intel.c:730:26: warning: cast to restricted __le16
  hci_intel.c:731:26: warning: cast to restricted __le16
  hci_intel.c:732:26: warning: cast to restricted __le16

because we access non-restricted types with le16_to_cpu().
More confusion is added by using above against u8. On big-endian
architecture we will get all zeroes. I bet it's not what should be
in such case.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_intel.c