bpf, sockhash: Synchronize_rcu before free'ing map
authorJakub Sitnicki <jakub@cloudflare.com>
Thu, 6 Feb 2020 11:16:51 +0000 (12:16 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 7 Feb 2020 21:36:26 +0000 (22:36 +0100)
commit0b2dc83906cf1e694e48003eae5df8fa63f76fd9
tree2cb216e87bfd171ea95e8af962f20ed0fa2a3e96
parentdb6a5018b6e008c1d69c6628cdaa9541b8e70940
bpf, sockhash: Synchronize_rcu before free'ing map

We need to have a synchronize_rcu before free'ing the sockhash because any
outstanding psock references will have a pointer to the map and when they
use it, this could trigger a use after free.

This is a sister fix for sockhash, following commit 2bb90e5cc90e ("bpf:
sockmap, synchronize_rcu before free'ing map") which addressed sockmap,
which comes from a manual audit.

Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200206111652.694507-3-jakub@cloudflare.com
net/core/sock_map.c