dmaengine: qcom: Always inline gpi_update_reg
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 12 Jan 2021 19:12:14 +0000 (12:12 -0700)
committerVinod Koul <vkoul@kernel.org>
Wed, 13 Jan 2021 11:21:17 +0000 (16:51 +0530)
commit0a6d3038d914b51d6860f23ea2b508590e8340de
tree9b345c4a46d895992436e0afdd0cf54b0e48b963
parent1f0a16f04113f9f0ab0c8e6d3abe661edab549e6
dmaengine: qcom: Always inline gpi_update_reg

When building with CONFIG_UBSAN_UNSIGNED_OVERFLOW, clang decides not to
inline gpi_update_reg, which causes a linkage failure around __bad_mask:

ld.lld: error: undefined symbol: __bad_mask
>>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)
>>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a
>>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)
>>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a

If gpi_update_reg is not inlined, the mask value will not be known at
compile time so the check in field_multiplier stays in the final
object file, causing the above linkage failure. Always inline
gpi_update_reg so that this check can never fail.

Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1243
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20210112191214.1264793-1-natechancellor@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/gpi.c