KVM: selftests: Gracefully handle empty stack traces
authorDavid Matlack <dmatlack@google.com>
Thu, 22 Sep 2022 23:17:23 +0000 (16:17 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 30 Sep 2022 10:38:00 +0000 (06:38 -0400)
commit09636efd1bd164ac782ff0d3a714db2c53964776
tree498b5df37ec1516e97c3360074fafbde9b7cad01
parent6336a810db5c7e8e48b55b12fbb5e9cbd36a3d19
KVM: selftests: Gracefully handle empty stack traces

Bail out of test_dump_stack() if the stack trace is empty rather than
invoking addr2line with zero addresses. The problem with the latter is
that addr2line will block waiting for addresses to be passed in via
stdin, e.g. if running a selftest from an interactive terminal.

Opportunistically fix up the comment that mentions skipping 3 frames
since only 2 are skipped in the code.

Cc: Vipin Sharma <vipinsh@google.com>
Cc: Sean Christopherson <seanjc@google.com>
Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20220922231724.3560211-1-dmatlack@google.com>
[Small tweak to keep backtrace() call close to if(). - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tools/testing/selftests/kvm/lib/assert.c