efi/libstub: Avoid returning uninitialized data from setup_graphics()
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Sun, 26 Apr 2020 19:49:46 +0000 (21:49 +0200)
committerArd Biesheuvel <ardb@kernel.org>
Thu, 30 Apr 2020 21:26:30 +0000 (23:26 +0200)
commit081d5150845ba3fa49151a2f55d3cc03b0987509
tree682a9e7339b4a44db3b7f9ce223a333a041c88d7
parenta088b858f16af85e3db359b6c6aaa92dd3bc0921
efi/libstub: Avoid returning uninitialized data from setup_graphics()

Currently, setup_graphics() ignores the return value of efi_setup_gop(). As
AllocatePool() does not zero out memory, the screen information table will
contain uninitialized data in this case.

We should free the screen information table if efi_setup_gop() returns an
error code.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Link: https://lore.kernel.org/r/20200426194946.112768-1-xypron.glpk@gmx.de
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/libstub/arm-stub.c