driver core: platform: fix u32 greater or equal to zero comparison
authorColin Ian King <colin.king@canonical.com>
Thu, 16 Jan 2020 17:57:58 +0000 (17:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Jan 2020 14:27:11 +0000 (15:27 +0100)
commit0707cfa5c3ef58effb143db9db6d6e20503f9dec
treef041064a7ada317cc4a11f7b4d3efeeaca6ebf13
parentf3c19481820cca412a768ae1d6737f59b68acfed
driver core: platform: fix u32 greater or equal to zero comparison

Currently the check that a u32 variable i is >= 0 is always true because
the unsigned variable will never be negative, causing the loop to run
forever.  Fix this by changing the pre-decrement check to a zero check on
i followed by a decrement of i.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 39cc539f90d0 ("driver core: platform: Prevent resouce overflow from causing infinite loops")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/20200116175758.88396-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/platform.c